Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial storage level and storage inflows #239

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

datejada
Copy link
Member

@datejada datejada commented Nov 8, 2023

Pull request details

Describe the changes made in this pull request

Add to the model the inflows and the energy storage initial level. This implies changes in the i/o, input data, and the model.

List of related issues or pull requests

Closes #198

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@datejada datejada self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/io.jl 100.00% <100.00%> (ø)
src/model.jl 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@datejada datejada requested a review from abelsiqueira November 8, 2023 14:26
@datejada datejada marked this pull request as ready for review November 8, 2023 14:30
@datejada datejada force-pushed the 198-add-storage-inflows branch from 6a02cfa to e31f226 Compare November 8, 2023 15:29
@datejada datejada requested review from greg-neustroev and removed request for abelsiqueira November 8, 2023 15:38
src/model.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@greg-neustroev greg-neustroev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 245-250 should be done with set_lower_bound()

@datejada datejada merged commit 5eec22a into TulipaEnergy:main Nov 8, 2023
6 checks passed
@datejada datejada deleted the 198-add-storage-inflows branch November 8, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Storage Inflows and Initial Storage Level data for the Hydro in the Norse Case
2 participants